Merge 'upstream': diagnostic-signs, nvim-dap lazy, which-key typo

- fix: which-key comment typo
- Fix nvim-dap not lazy loading
- feat: Change to prepare for upcoming deprecation of configuring diagnostic-signs using sign_define()

lua/kickstart/plugins/debug.lua

@@ -24,28 +24,59 @@ return {
     -- Add your own debuggers here
     'leoluz/nvim-dap-go',
   },
-  keys = function(_, keys)
+  keys = {
-    local dap = require 'dap'
+    -- Basic debugging keymaps, feel free to change to your liking!
-    local dapui = require 'dapui'
+    {
-    return {
+      '<F5>',
-      -- Basic debugging keymaps, feel free to change to your liking!
+      function()
-      { '<F5>', dap.continue, desc = 'Debug: Start/Continue' },
+        require('dap').continue()
-      { '<F1>', dap.step_into, desc = 'Debug: Step Into' },
+      end,
-      { '<F2>', dap.step_over, desc = 'Debug: Step Over' },
+      desc = 'Debug: Start/Continue',
-      { '<F3>', dap.step_out, desc = 'Debug: Step Out' },
+    },
-      { '<leader>b', dap.toggle_breakpoint, desc = 'Debug: Toggle Breakpoint' },
+    {
-      {
+      '<F1>',
-        '<leader>B',
+      function()
-        function()
+        require('dap').step_into()
-          dap.set_breakpoint(vim.fn.input 'Breakpoint condition: ')
+      end,
-        end,
+      desc = 'Debug: Step Into',
-        desc = 'Debug: Set Breakpoint',
+    },
-      },
+    {
-      -- Toggle to see last session result. Without this, you can't see session output in case of unhandled exception.
+      '<F2>',
-      { '<F7>', dapui.toggle, desc = 'Debug: See last session result.' },
+      function()
-      unpack(keys),
+        require('dap').step_over()
-    }
+      end,
-  end,
+      desc = 'Debug: Step Over',
+    },
+    {
+      '<F3>',
+      function()
+        require('dap').step_out()
+      end,
+      desc = 'Debug: Step Out',
+    },
+    {
+      '<leader>b',
+      function()
+        require('dap').toggle_breakpoint()
+      end,
+      desc = 'Debug: Toggle Breakpoint',
+    },
+    {
+      '<leader>B',
+      function()
+        require('dap').set_breakpoint(vim.fn.input 'Breakpoint condition: ')
+      end,
+      desc = 'Debug: Set Breakpoint',
+    },
+    -- Toggle to see last session result. Without this, you can't see session output in case of unhandled exception.
+    {
+      '<F7>',
+      function()
+        require('dapui').toggle()
+      end,
+      desc = 'Debug: See last session result.',
+    },
+  },
   config = function()
     local dap = require 'dap'
     local dapui = require 'dapui'

lua/kickstart/plugins/lspconfig.lua

@@ -152,11 +152,12 @@ return {
 
       -- Change diagnostic symbols in the sign column (gutter)
       -- if vim.g.have_nerd_font then
-      --   local signs = { Error = '', Warn = '', Hint = '', Info = '' }
+      --   local signs = { ERROR = '', WARN = '', INFO = '', HINT = '' }
+      --   local diagnostic_signs = {}
       --   for type, icon in pairs(signs) do
-      --     local hl = 'DiagnosticSign' .. type
+      --     diagnostic_signs[vim.diagnostic.severity[type]] = icon
-      --     vim.fn.sign_define(hl, { text = icon, texthl = hl, numhl = hl })
       --   end
+      --   vim.diagnostic.config { signs = { text = diagnostic_signs } }
       -- end
 
       -- LSP servers and clients are able to communicate to each other what features they support.

lua/kickstart/plugins/which-key.lua

@@ -22,7 +22,7 @@ return {
         -- set icon mappings to true if you have a Nerd Font
         mappings = vim.g.have_nerd_font,
         -- If you are using a Nerd Font: set icons.keys to an empty table which will use the
-        -- default whick-key.nvim defined Nerd Font icons, otherwise define a string table
+        -- default which-key.nvim defined Nerd Font icons, otherwise define a string table
         keys = vim.g.have_nerd_font and {} or {
           Up = '<Up> ',
           Down = '<Down> ',